Skip to content

docs: Improve client class comment #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: Improve client class comment #258

wants to merge 1 commit into from

Conversation

anubhav756
Copy link
Contributor

No description provided.

@anubhav756 anubhav756 self-assigned this May 23, 2025
@anubhav756 anubhav756 requested a review from a team as a code owner May 23, 2025 11:21
@anubhav756 anubhav756 mentioned this pull request May 23, 2025
Merged
@twishabansal
Copy link
Contributor

Right now, we're closing the session regardless of if the user provides it. Should we add this change to #260?

@anubhav756
Copy link
Contributor Author

anubhav756 commented May 26, 2025 •
edited
Loading

Right now, we're closing the session regardless of if the user provides it. Should we add this change to #260?

Merged this with #260 since this change is relatively small and is much related to that PR.

@anubhav756 anubhav756 closed this May 26, 2025
@anubhav756 anubhav756 deleted the anubhav-patch branch May 26, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

@twishabansal twishabansal Awaiting requested review from twishabansal

Assignees

@anubhav756 anubhav756

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anubhav756 @twishabansal @kurtisvg